C++ Tutorials - Absolute n00b spoonfeed

guys pls help me this is driving me crazy!!. i have a runtime error in that part of my code(tic tac toe) and i dunno why. can u spot the bug out for me?

Code: Select all

#include <iostream>
#include <string>

using namespace std;

int main()
{
    //Display the board
   
   
   
    const int ROWS = 3;
    const int COLLUMNS = 3;
   
    char board[ROWS][COLLUMNS] = {{'-', '-', '-'},
                                  {'-', '-', '-'},
                                  {'-', '-', '-'}};
   
    for(int i = 0;i < ROWS; ++i)
    {
       for(int j = 0;j < COLLUMNS; ++j)
       {
       cout << board[i][j];
       }
       cout<<endl;
    }
    //X or O?
   
   
   
    char charSelect, chara, oppChara;
    do
    {
       cout << "Please select whether you want to use an X or an O\n";
       cin >> charSelect;
       
if(charSelect == 'X'||charSelect == 'x')
        chara = 'X';
        if(charSelect == 'O'||charSelect == 'o')
        chara = 'O';
        else
        cout << "Invalid choice\n";
    }
        while(charSelect!='x'&&charSelect !='X'&&charSelect != 'o'&&charSelect != 'O');
       
        if (chara == 'X')
        oppChara = 'O';
        if(chara == 'O');
        oppChara = 'X';
       
        cout << "OK then your opponent has "<<oppChara<<endl;
       
       
       
       system("pause");
       
       return 0;
}


I don't now if your compiler didn't give you a warrning or not but you had a semicolon after a if statement

Code: Select all

  if(chara == 'O');


also here is a problem with your if at the top

Code: Select all

if(charSelect == 'X'||charSelect == 'x')
        chara = 'X';
        if(charSelect == 'O'||charSelect == 'o')
        chara = 'O';
        else
        cout << "Invalid choice\n";


you need to make the second if a else if

Code: Select all

  else if(charSelect == 'O'||charSelect == 'o')


because if you choose X then the second if will be false and run the else statement

I did not get an error myself so try that first and see if that was your problem

thanks so much