C++ Tutorials - Absolute n00b spoonfeed

Did you try compiling it before you posted it, I got multiple errors. you forgot to put in two headers . and one of them will clash with another header.
C++ gave me two solutions to this problem the second one I'll show here

Code: Select all

#define NOMINMAX //limits and windows both have a max in their headers so this will fix the problem thanks to C++

#include <limits>
#include <ctime>



I haven't had a chance to look at it yet I thought I would post this so anybody trying to run it will have a fix to it

alright I looked at it a little bit and here is an idea but you would have to redo a lot and if you did this without doing it it won't compile but its more what the classes are suppose to be used like.

Code: Select all

class Playerstats
{
   public:

      Playerstats(){}//default constructor
      ~Playerstats(){}//destructor

      PlayerStats(int _health, int _maxHealth, unsigned int _mana, unsigned int _maxMana) :
      health(_health),      //this is the initializer list
        maxHealth(_maxHealth),
        mana(_mana),
        maxMana(_maxMana)
      {}   //if you had other stuff to do you would do it in here

      int GetHealth(){return health;}//this is how you would call your private stuff
      int GetMaxHealth(){return maxHealth;}
      int GetMana(){return mana;}
      int GetMaxMana(){return maxMana;}

   private:
                 
        int health;
        int maxHealth;
        unsigned int mana;
        unsigned int maxMana;
};


you would want to make another class for the battle and make member functions to add/subtract or do whats needed with the values
I know its a little vague what I'm saying but to show it I would have to rewrite it and I'm busy working on mine right now

One thing you did with your class is you had made two when one was fine

Code: Select all

Playerstats p1(20000,20000,15000,15000);
Playerstats p2(20000,20000,15000,15000);


I changed the class name to fit better since only one was needed, you don't have to match the values either they are two separate entity's.
sorry if I sound a little gruff I'm not meaning too I have a tendency to be straight to the point so it may sound cold.
just ask if any of this sounds confusing to you.

Here is a little example of what I'm saying

//playerstats.h

Code: Select all

#ifndef PLAYERSTATS_H
#define PLAYERSTATS_H

class Playerstats
    {
       public:

          Playerstats(){}//default constructor
          ~Playerstats(){}//destructor

          Playerstats(int , int , unsigned int , unsigned int );
         

          int GetHealth(){return health;}//this is how you would call your private stuff
          int GetMaxHealth(){return maxHealth;}
          int GetMana(){return mana;}
          int GetMaxMana(){return maxMana;}

        void AddHealth(int);//this is how you would add,subttract or whatever is need to you private stuff
        void AddMana(int);
        void SubtractHealth(int);
        void SubtractMana(int);

       private:
                     
            int health;
            int maxHealth;
            unsigned int mana;
            unsigned int maxMana;
    };

#endif


//playerstats.cpp

Code: Select all

#include "playerstats.h"

Playerstats::Playerstats(int _health, int _maxHealth, unsigned int _mana, unsigned int _maxMana) :
          health(_health),      //this is the initializer list
            maxHealth(_maxHealth),
            mana(_mana),
            maxMana(_maxMana)
          {}   //if you had other stuff to do you would do it in here

void Playerstats::AddHealth(int addH)//you must add Playerstats:: to each one so the compiler nows who it belongs to
{
   health += addH;
}
void Playerstats::AddMana(int addM)
{
   mana += addM;
}
void Playerstats::SubtractHealth(int subH)
{
   health -= subH;
}
void Playerstats::SubtractMana(int subM)
{
   mana -= subM;
}


//main

Code: Select all

#include <iostream>
#include "playerstats.h"

int main()
{
   int healthRegen = 1000;
   int attackDamage = 200;

   Playerstats p1(20000,20000,10000,15000);// this passes all to the constructor to initialize
   Playerstats p2(10000,10000,25000,25000);//I changed the stats on this one

   std::cout<< "Player ones health "<< p1.GetHealth()
      << " Player twos health " << p2.GetHealth() << "\n"; //shows they are different

    if ( p1.GetMana() < p1.GetMaxMana() )//these are just examples of how to use them
    {
       std::cout<< p1.GetMana() << "\n";
       p1.AddMana(5000);
       std::cout<< p1.GetMana() << "\n";
    }

    std::cout<< "Player gets attacked\n";
    p2.SubtractHealth(attackDamage * 2);
    std::cout<< "You now have " << p2.GetHealth() << "\n";
    p2.AddHealth(healthRegen);
    std::cout<< "You use mana regen now you have " << p2.GetHealth() << "\n";
}


I try to show you how to call your private stuff and also to show you that your p1 and p2 are different. as you see the functions in playerstats.cpp both p1 and p2 use the same functions but there values are completely different. As you can see to use class in its proper way you would have to do a lot of editing to your project. oh by the way don't forget to put these after your member function calls () I can't tell you how many times I do that and can't figure out why I'm getting errors. VS intelesence doesn't spit them out so I forget to add them.
hope that helps a little if not just ask